Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Focus command to focus on specific monitor by index #683

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

hiszd
Copy link
Contributor

@hiszd hiszd commented Aug 19, 2024

This PR is to add a command option to the focus command that allows you to focus on a specific monitor by index.
And example usage of this would be:

glazewm.exe command focus --monitor 1

This would focus on the second monitor.
The indexing is zero-based, so the first monitor would be monitor 0.

packages/wm/src/monitors/commands/focus_monitor.rs Outdated Show resolved Hide resolved
packages/wm/src/monitors/commands/focus_monitor.rs Outdated Show resolved Hide resolved
packages/wm/src/monitors/commands/focus_monitor.rs Outdated Show resolved Hide resolved
packages/wm/src/monitors/commands/focus_monitor.rs Outdated Show resolved Hide resolved
@lars-berger
Copy link
Member

Sweet, thanks for the pr! Some minor fixes otherwise it's looking good

@hiszd
Copy link
Contributor Author

hiszd commented Aug 20, 2024

Thank you for the review.
I have made the requested changes and all should look good now.

@lars-berger lars-berger merged commit d548c7d into glzr-io:main Aug 31, 2024
1 check passed
@lars-berger
Copy link
Member

Thank you 🙌 Hope you don't mind but did some minor tweaks so that we could avoid the unwrap calls

Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants