-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new config general.shutdown_commands
and general.reload_commands
and shutdown/reload Zebar along side the WM
#713
feat: add new config general.shutdown_commands
and general.reload_commands
and shutdown/reload Zebar along side the WM
#713
Conversation
Good One! This is necessary. |
Really well written, thanks for taking care of this 🙌 Just a couple nitpicks, otherwise good to go |
I have refactored the code. |
Sweet looks great 👌 |
Hey @JonasWischeropp quick heads up - did some minor fixups in a follow-up pr at #742 didn't manage to get the Zebar config reload command to work (could be a change in Zebar v1 -> v2 that changed the behavior), so i'll remove that for now until a CLI command is added to Zebar for reloading |
BTW will get around to reviewing your new PR shortly 👌 Sorry about the wait |
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR addresses #650 and #646
I added two config entries that allow easy execution of commands at shutdown and restart similar to
general.startup_commands
.general.shutdown_commands
general.reload_commands
These are then used in the sample config to shutdown and reload Zebar.