Slight improvements to use this library with native ESP8266 Ethernet drivers such as lwIP_enc28j60 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather a solution that do not force to modify existing examples. This direction would break all former code using older versions. I guess using preprocessor directives like |
|
Only by restarting the device and applying the connection settings, it is possible to change the mode from WiFi to Ethernet at runtime. In this case, the preprocessor is not a good solution. While using weak functions allows you to use this library on other platforms ( which support AsyncUDP ) with a few changes. |
|
I changed the default of weak functions to be compatible with the old versions ..... |
|
Conflicts were resolved ..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gmag11
I added some weak functions to use this library with native ESP8266 Ethernet drivers such as lwIP_enc28j60
( Sorry I made a mistake in creating pull request, please delete my invalid pull requests )