Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-level setup.py #36

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add top-level setup.py #36

wants to merge 3 commits into from

Conversation

chajath
Copy link

@chajath chajath commented Sep 28, 2022

With this, we can now pip install directly from the repo dir.

See #35.

We can potentially package up experiments as an extra installable (i.e., via huggingmolecules[experiments]). I will do in a follow-up if necessary.

@panpiort8
Copy link
Collaborator

Thank you very much for the engagement!
The code looks good, but the PR indeed needs some more work to sew it up:

  • update Installation guide in README.md,
  • as you suggested, package the experiments module.

If you are willing to do the tasks, I'll be really glad :) if not, simply let me know, and I will take this PR over.

@chajath
Copy link
Author

chajath commented Oct 24, 2022

Hi! Sorry I won't have the bandwidth to follow up on the changes. Please feel free to take this PR over.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants