Fix hopper counters command error when guessing item color #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely pending a bigger refactor to that, ideally in a way a generic change like this gets noticed next time
Gets the item being searched once outside instead of getting the id for every recipe
|
This is also used by the |
altrisi
added a commit
that referenced
this pull request
Oct 6, 2023
* Fix hopper counters command crash when guessing item color * Less List types, slightly less copying and clearer Stream chain * Reverse result equal logic to not search through registries as much Gets the item being searched once outside instead of getting the id for every recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1825
I'd say warrants a 1.20.2 release.