Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for sound presence from Scarpet's sound function #1834

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Remove check for sound presence from Scarpet's sound function #1834

merged 6 commits into from
Jan 18, 2024

Conversation

17183248569
Copy link
Contributor

to fix #1832

@17183248569 17183248569 marked this pull request as ready for review October 21, 2023 20:34
@szdytom szdytom mentioned this pull request Oct 22, 2023
Closed
@altrisi altrisi added the scarpet Issues related to scarpet in some way label Oct 22, 2023
@altrisi altrisi changed the title remove this try-catch about sound? Remove check for sound present in registries from Scarpet's sound function Oct 22, 2023
altrisi
altrisi reviewed Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@altrisi altrisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense that sounds wouldn't be on the server.

Do you know if there is any way to add those to the server so they appear in the list? Or does the server just not load those (I assume the only way would be from datapacks, that idk if they can do sound).

src/main/java/carpet/script/exception/Throwables.java Outdated Show resolved Hide resolved
docs/scarpet/api/Auxiliary.md Show resolved Hide resolved
src/main/java/carpet/script/api/Auxiliary.java Show resolved Hide resolved
altrisi
altrisi approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@altrisi altrisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay!

@altrisi altrisi changed the title Remove check for sound present in registries from Scarpet's sound function Remove check for sound presence from Scarpet's sound function Jan 18, 2024
@altrisi altrisi merged commit 4aec811 into gnembon:master Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altrisi altrisi altrisi approved these changes

Assignees
No one assigned
Labels
scarpet Issues related to scarpet in some way
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[scarpet] unknown_sound error when loading a custom sound in resource pack
2 participants
@17183248569 @altrisi