Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.21-pre2 #1919

Closed
wants to merge 2 commits into from
Closed

Update to 1.21-pre2 #1919

wants to merge 2 commits into from

Conversation

axialeaa
Copy link

Requires changing LivingEntity_creativeFlyMixin#canChangeDimensions target, as canChangeDimensions() is no longer overridden in LivingEntity.class. I have changed it to target canUsePortal() instead which has a different purpose to canChangeDimensions(), so please let me know if this is not a good fix.

voidpointer0x00
voidpointer0x00 approved these changes Jun 1, 2024
View reviewed changes
Copy link

@voidpointer0x00 voidpointer0x00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original method was just renamed (implementations match), can confirm that creativeNoClip still works

@axialeaa axialeaa mentioned this pull request Jun 2, 2024
Closed
@axialeaa axialeaa closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voidpointer0x00 voidpointer0x00 voidpointer0x00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axialeaa @voidpointer0x00