Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build problems in dockerfile in prod stage #54

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Build problems in dockerfile in prod stage #54

merged 1 commit into from
Sep 12, 2024

Conversation

sw360cab
Copy link
Contributor

Fixing not building Dockerfile in CI when using Dockerfile.production

@sw360cab sw360cab requested review from alexiscolin and a team as code owners September 12, 2024 12:09
@netlify Netlify
Copy link

netlify bot commented Sep 12, 2024 •
edited
Loading

✅ Deploy Preview for gno-docs ready!

Name Link
🔨 Latest commit 5cecc2a
🔍 Latest deploy log https://app.netlify.com/sites/gno-docs/deploys/66e2da0c4804960008dd18fe
😎 Deploy Preview https://deploy-preview-54--gno-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 91
Accessibility: 95
Best Practices: 100
SEO: 90
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

thehowl
thehowl approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have the ci workflow to build docker images also on pull requests, without pushing them.

@sw360cab
Copy link
Contributor Author

would be nice to have the ci workflow to build docker images also on pull requests, without pushing them.

You mean to build on a new PR and (also) push it on merged PR ?

@sw360cab sw360cab merged commit 0d3fe64 into main Sep 12, 2024
5 checks passed
@sw360cab sw360cab deleted the fix/docker-prod branch September 12, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@alexiscolin alexiscolin alexiscolin approved these changes

@thehowl thehowl thehowl approved these changes

@deelawn deelawn Awaiting requested review from deelawn deelawn is a code owner automatically assigned from gnolang/tech-staff

@mvertes mvertes Awaiting requested review from mvertes mvertes is a code owner automatically assigned from gnolang/tech-staff

Assignees
No one assigned
Labels
None yet
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sw360cab @thehowl @alexiscolin @zivkovicmilos