-
Notifications
You must be signed in to change notification settings - Fork 388
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(contribs/gnomd): patch dependencies, add linter, remove ioutils (#…
…3575) This is a PR primarily focused on updating direct and transitive dependencies to address security patching for this tool, while this doesn't currently include tests, I did add `make lint` in the same pattern used by other contribs. I also used the opportunity to remove `ioutil` in favor of the more modern `io` and `os` functions that are supported in go stdLib moving forward.
- Loading branch information
Showing
4 changed files
with
51 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
rundep := go run -modfile ../../misc/devdeps/go.mod | ||
golangci_lint := $(rundep) github.com/golangci/golangci-lint/cmd/golangci-lint | ||
|
||
|
||
.PHONY: install test lint | ||
install: | ||
go install . | ||
|
||
test: | ||
@echo "XXX: add tests" | ||
|
||
lint: | ||
@echo "XXX: add lint" | ||
$(golangci_lint) --config ../../.github/golangci.yml run ./... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters