chore: fix issues reported by go vet

[mvertes]

Passing go vet is the minimum level of code quality for a go project. This is addressed here for the full mono-repo. Mainly trivial changes, except for a few copy lock issues which could be more meaningful (kept for a separate pull request).

Addresses #2954 (but not sufficient to close it yet).

Hint for reviewers: it's easier to review each commit individually.

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[codecov]

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 61.10%. Comparing base (2c04ff0) to head (fbc1d89).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
gno.land/pkg/gnoweb/gnoweb.go	0.00%	2 Missing ⚠️
gno.land/pkg/sdk/vm/builtins.go	0.00%	2 Missing ⚠️
gnovm/tests/file.go	0.00%	2 Missing ⚠️
tm2/pkg/bft/consensus/state.go	81.81%	2 Missing ⚠️
tm2/pkg/db/boltdb/boltdb.go	0.00%	2 Missing ⚠️
tm2/pkg/p2p/switch.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2952   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files         564      564           
  Lines       75359    75355    -4     
=======================================
- Hits        46045    46043    -2     
+ Misses      25950    25947    -3     
- Partials     3364     3365    +1     

Flag	Coverage Δ
contribs/gnodev	61.46% <ø> (ø)
contribs/gnofaucet	14.46% <ø> (ø)
gno.land	67.92% <0.00%> (ø)
gnovm	66.17% <33.33%> (ø)
misc/genstd	80.54% <ø> (ø)
misc/logos	19.88% <ø> (ø)
tm2	62.05% <76.19%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thehowl]

Can you also add the govet linter to .golangci.yml?

See: https://golangci-lint.run/usage/linters/#govet

[mvertes]

I will be happy to add govet to the CI, once we pass it 100%. Another PR is necessary to address the passing of Mutex by value, never a good sign, and more delicate to fix than the trivial changes here.

[mvertes]

Ok. I see that there is already some comments //nolint:govet at the offender places (cough...), so yes, give it a try to govet in CI!