fix(tm2): avoid mutex copy in marshal and unmarshal methods #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid copying of Mutex at several places. Add missing lock / unlock calls. Improve test coverage for protobuf timestamp and duration. `go vet` doesn't complain anymore on Mutex copy. Addresses gnolang#2954.
mvertes
requested review from
jaekwon,
moul,
piux2 and
zivkovicmilos
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2981 +/- ##
==========================================
+ Coverage 61.10% 63.08% +1.98%
==========================================
Files 564 563 -1
Lines 75355 79950 +4595
==========================================
+ Hits 46045 50436 +4391
- Misses 25945 26131 +186
- Partials 3365 3383 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid copying of Mutex at several places.
Add missing lock / unlock calls.
Improve test coverage for protobuf timestamp and duration.
go vetdoesn't complain anymore on Mutex copy.Addresses #2954.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description