-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gno version command #3002
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Can you fix the failed CI test?
|
Please, be aware of this -> #2755 (comment) |
I've modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes:
- Instead of having this in cmd/gno, make a package
gnovm/pkg/version
, withvar Version = "develop"
- This will default to "develop" as a version, when somebody uses
go install
/go build
directly. - It also allows us to eventually have this as
gnoland version
, too.
- This will default to "develop" as a version, when somebody uses
- The ldflag should also go in the goreleaser set up:
.github/goreleaser.yml
Marking draft for now while we wait for changes; put back into ready for review when changes are applied. |
if I understand correctly, I create the |
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
yes (though it likely needs a new file in cmd/gno, like most commands) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean
I've added the
version
command to gno to get the version of gno that is installedContributors' checklist...
BREAKING CHANGE: xxx
message was included in the description