chore(otel): Open Telemetry metrics fixed and provided with demo example #3038
+257
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sw360cab
commented
Oct 28, 2024
sw360cab
commented
- Redefine and cleanup Open Telemetry metrics types and usage
- Rehauled demo example adding a minimal sample of RCP + Validator Node
github-actions
bot
added
📦 🌐 tendermint v2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3038 +/- ##
==========================================
- Coverage 63.34% 63.34% -0.01%
==========================================
Files 548 548
Lines 78646 78621 -25
==========================================
- Hits 49817 49801 -16
+ Misses 25467 25458 -9
Partials 3362 3362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Oct 30, 2024
|
maybe @zivkovicmilos can take a second look / merge. |
thehowl
reviewed
Nov 6, 2024
Comment on lines
+51
to
+54
| gnoland genesis generate | ||
| gnoland genesis validator add -name val000 -address $(gnoland secrets get validator_key.address -raw) -pub-key $(gnoland secrets get validator_key.pub_key -raw) | ||
| gnoland genesis balances add -balance-sheet /gnoroot/gno.land/genesis/genesis_balances.txt | ||
| gnoland genesis txs add packages /gnoroot/examples/gno.land |
There was a problem hiding this comment.
I was about to merge it, but I guess this needs gnogenesis now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.