chore(gnokey): in maketx addpkg, change -deposit to -send
#3122
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leohhhn
changed the title
maketx addpkg, change deposit to sendmaketx addpkg, change -deposit to -send
github-actions
bot
added
the
📦 ⛰️ gno.land
leohhhn
changed the title
maketx addpkg, change -deposit to -sendmaketx addpkg, change -deposit to -send
jefft0
added
the
review/triage-pending
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3122 +/- ##
==========================================
- Coverage 63.79% 63.78% -0.01%
==========================================
Files 549 549
Lines 78819 78817 -2
==========================================
- Hits 50279 50277 -2
Misses 25150 25150
Partials 3390 3390 ☔ View full report in Codecov by Sentry. |
|
@leohhhn, can you fix the failed CI tests? |
|
Can we wait to do this until we decide if we want to rename OrigSend to something like Deposit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the
depositflag tosend. I think this change makes sense from the consistency perspective. I've had multiple times happen where I'm trying to deploy something with some initial balance, trying-send, only realizing that it's-depositin this case.It's quite obvious that the
sendwill go to the deployed realm's address, so I think it's a valid change.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description