-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): modify pausable #3628
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code does what the PR description says that it does. There is a test for new functions. All CI checks pass (except "Merge Requirements" as usual). Ready for a core dev to decide if this change is wanted.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Description
Prevously, the
pausable
object embedded theownable
object directly, and with the intended usage of both packages being the following,ownable
functions were being duplicated:This PR names the
ownable
insidepausable
as a private field and exposes a getter in case someone needs it for some reason. It also removes theNew()
function, which doesn't make too much sense right now as the pausable needs to be paired withownable
- this might change later but for now this should be the way.