-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): correct filetest directive behavior #3697
fix(gnovm): correct filetest directive behavior #3697
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we had instead at the beginning of runFiletest
, something like:
if dirs.First(DirectiveOutput) == nil && dirs.First(DirectiveError) == nil {
return "", errors.New("all filetests require at least an Output or Error directive")
}
3dc3aa8
to
b7c3380
Compare
Sometimes it's not necessary to set a directive, all we need is that it's not panicking, e.g. package main
var a int
var b string
... The key issue is that a proper directive must be provided whenever an Error or Output occurs. This ensures that the system can handle these events appropriately and take the necessary actions. Thank for the review. @thehowl |
The test result is misleading. Without an output directive set, the current logic does not provide a prompt even when actual output occurs.
before fix:
=== RUN TestFiles
=== PAUSE TestFiles
=== CONT TestFiles
=== RUN TestFiles/a111.gno
--- PASS: TestFiles (0.14s)
--- PASS: TestFiles/a111.gno (0.01s)
PASS
ok command-line-arguments 1.619s
after fix:
=== RUN TestFiles
=== PAUSE TestFiles
=== CONT TestFiles
=== RUN TestFiles/a111.gno
files_test.go:92: unexpected output:
ok
--- FAIL: TestFiles (0.13s)
--- FAIL: TestFiles/a111.gno (0.01s)
FAIL
FAIL command-line-arguments 1.479s
FAIL