-
Notifications
You must be signed in to change notification settings - Fork 405
feat(ufmt): enhance printf functionnalities by adding flags #4136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* includes gnominers * includes home * include pure packages
* reorganise gnominers into submodules * create the dao submodule * add the tofix folder with all broken features * create the minerdao /!\ DAO DOESNT WORK RN BECAUSE OF CYCLE DEPENDANCIES /!\
* i didnt use subfolders
* add precisision flag ("%.2f") * add 0 & ' ' flags ("%03d", "% 3d") * add length parsing (not used rn) * add # for hex ("%#02x") * add %i & %X (%i is just %d, %X is big hex) * change the home * ass some tests to handle what ive done
* also changed my home page so it displays a number
Format -> FormatRound because it rounds...
* cause of major issue because it was reading to far
* better messages * better formatting * use `p/moun/md` for md formatting in users.gno
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Can you split it into two? |
@thehowl done |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few comments. I would appreciate if you could check them 👍
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
* fix oldLen and oldString that was stored and not updated in the precision changed, so it was checking the old string instead of the fresh new one * added tests to handle the special case of %.000000f
@notJoon i'm done fixing everything 👍 i just need your opinion on something (concerning backward pointer checking usefullness) |
tell me if i need to add anything else ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that all the requested changes have been reflected and all tests have passed.
It's a minor point related to policy, but the "resolve conversation" button should not be pressed until the reviewer has checked it. Please refer to this document for more details.
Anyway, except for this, everything else looks good.
remove: review/triage-pending
flag
Hmm... When using I'll check this problem today. If it's okay, may I modify this code together with you? |
totally fine for me, @notJoon ! but maybe it's because of the maps, so when you'll test, can you try putting the maps in the scope like i did, even if it's more greedy on memory ? |
Fixes
ufmt/printf
%.number
,%#
,%0
, and others