Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix about ngx_http_upstream_fair_update_nreq #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug fix about ngx_http_upstream_fair_update_nreq #5

wants to merge 1 commit into from

Conversation

atomd-zz
Copy link

In #4

static void
ngx_http_upstream_fair_update_nreq(ngx_http_upstream_fair_peer_data_t *fp, int delta, ngx_log_t *log)
{
    #if (NGX_DEBUG)
    ...
    nreq = (fp->peers->peer[fp->current].shared->nreq += delta);
    total_nreq = (fp->peers->shared->total_nreq += delta);
    ...
    #endif
}

If there is no debug mode, ngx_http_upstream_fair_update_nreq has no effect.

@gnosek
Copy link
Owner

gnosek commented Jan 30, 2012

Oops.

Does your patch compile cleanly with and without NGX_DEBUG? I'd be more comfortable with leaving the ifdef around ngx_log_debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants