[Viewer] Only update order balance if it isn't filtered out

[nlordell]

This PR updates an order balance only if it is considered valid (i.e. matches the token filter or is valid for the specified batch) for some super awesome gas savings.

Test Plan

Deployed on Rinkeby and was able to go through 7 pages of unfiltered orders compared to 3 pages of unfiltered orders. We identify calls to getEncodedUserOrders by calls to getUsersPaginated since it is only used there.

[nlordell]

This might cause problems though, since retrieving "full" pages (i.e. pages with many orders that are considered valid) is considerably more expensive than "empty" pages (i.e. pages with few orders that are considered valid) and hence, the gas check that we currently perform might not be good enough.

[bh2smith]

Short and sweet, wins the race! Super awesome gas savings you have there.

[fleupold]

This might cause problems though, since retrieving "full" pages (i.e. pages with many orders that are considered valid) is considerably more expensive than "empty" pages (i.e. pages with few orders that are considered valid) and hence, the gas check that we currently perform might not be good enough.

Yes, I think this is quite worrying as it makes our already brittle logic there even harder to reason about. I would like to see us move to a fixed "worst-case gas required for next loop" logic (maybe with a factor for page size), before landing this change.

I do agree the gas savings are likely going to be awesome.

[nlordell]

"worst-case gas required for next loop"

Time to tenderly again! Woohoo!

before landing this change.

I also agree, I'll leave the PR open for now until we implement something like that.

[nlordell]

Created #678 and placed this PR on hold.