Refactor for the newest PMAT #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongzii
commented
Sep 5, 2024
| @@ -35,28 +37,14 @@ def market_insights(market_id: HexAddress) -> MarketInsightsResponse: | |||
| status_code=404, detail=f"Market with id `{market_id}` not found." | |||
| ) | |||
| try: | |||
| insights = tavily_insights(market.question_title) | |||
| tavily_response = tavily_search( | |||
There was a problem hiding this comment.
Use tavily search from PMAT instead of re-implementing it in this repo
kongzii
commented
Sep 5, 2024
| ) | ||
| except ValueError as e: | ||
| logger.error( | ||
| f"Error deserializing MarketInsightsResponse from cache for {market_id=} and {item=}: {e}" |
There was a problem hiding this comment.
It could happen that Pydantic model and serialized results in database became out of sync. In that case, log error but pretend that it simply wasn't in the cache, to keep the API functional.
evangriffiths
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.