-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent deployment tooling #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small tweaks
def answer_binary_market(self, market: AgentMarket) -> bool: | ||
raise NotImplementedError("This method should be implemented by the subclass") | ||
|
||
def deploy( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this method used somewhere? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's a placeholder for now until we have a nice way of merging deploy_to_gcp
into it. For now I've added a pytest
Is there a need for the agent.py I created before? Feel free to remove it if not. |
I guess not, unless we want to keep it here when we pull out the deployment code into the separate repo. I've deleted, but happy to leave in if you prefer. |
Co-authored-by: Peter Jung <[email protected]>
…ion-market-agent into evan/deploy-agent
No description provided.