feat: panic with error msg

gnoswap-labs · Dec 20, 2024 · 38ca791 · 38ca791
1 parent cc23954
commit 38ca791
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/position/errors.gno b/position/errors.gno
@@ -7,18 +7,19 @@ import (
 )
 
 var (
-	errNoPermission   = errors.New("[GNOSWAP-POSITION-001] caller has no permission")
-	errSlippage       = errors.New("[GNOSWAP-POSITION-002] slippage failed")
-	errWrapUnwrap     = errors.New("[GNOSWAP-POSITION-003] wrap, unwrap failed")
-	errOutOfRange     = errors.New("[GNOSWAP-POSITION-004] out of range for numeric value")
-	errInvalidInput   = errors.New("[GNOSWAP-POSITION-005] invalid input data")
-	errDataNotFound   = errors.New("[GNOSWAP-POSITION-006] requested data not found")
-	errExpired        = errors.New("[GNOSWAP-POSITION-007] transaction expired")
-	errWugnotMinimum  = errors.New("[GNOSWAP-POSITION-008] can not wrap less than minimum amount")
-	errNotClear       = errors.New("[GNOSWAP-POSITION-009] position is not clear")
-	errZeroLiquidity  = errors.New("[GNOSWAP-POSITION-010] zero liquidity")
-	errPositionExist  = errors.New("[GNOSWAP-POSITION-011] position with same tokenId already exists")
-	errInvalidAddress = errors.New("[GNOSWAP-POSITION-012] invalid address")
+	errNoPermission         = errors.New("[GNOSWAP-POSITION-001] caller has no permission")
+	errSlippage             = errors.New("[GNOSWAP-POSITION-002] slippage failed")
+	errWrapUnwrap           = errors.New("[GNOSWAP-POSITION-003] wrap, unwrap failed")
+	errOutOfRange           = errors.New("[GNOSWAP-POSITION-004] out of range for numeric value")
+	errInvalidInput         = errors.New("[GNOSWAP-POSITION-005] invalid input data")
+	errDataNotFound         = errors.New("[GNOSWAP-POSITION-006] requested data not found")
+	errExpired              = errors.New("[GNOSWAP-POSITION-007] transaction expired")
+	errWugnotMinimum        = errors.New("[GNOSWAP-POSITION-008] can not wrap less than minimum amount")
+	errNotClear             = errors.New("[GNOSWAP-POSITION-009] position is not clear")
+	errZeroLiquidity        = errors.New("[GNOSWAP-POSITION-010] zero liquidity")
+	errPositionExist        = errors.New("[GNOSWAP-POSITION-011] position with same tokenId already exists")
+	errInvalidAddress       = errors.New("[GNOSWAP-POSITION-012] invalid address")
+	errPositionDoesNotExist = errors.New("[GNOSWAP-POSITION-013] position does not exist")
 )
 
 func addDetailToError(err error, detail string) string {

diff --git a/position/position.gno b/position/position.gno
@@ -356,8 +356,10 @@ func increaseLiquidity(params IncreaseLiquidityParams) (uint64, *u256.Uint, *u25
 
 	updated := setPosition(params.tokenId, position)
 	if !updated {
-		// TODO:
-		panic("position should be updated, not newly created")
+		panic(addDetailToError(
+			errPositionDoesNotExist,
+			ufmt.Sprintf("position(%d) doesn't exist", params.tokenId),
+		))
 	}
 
 	return params.tokenId, liquidity, amount0, amount1, position.poolKey