GSW-1839 Refactor/position contract utils #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- integrated helper with nft helper - add test helper code - add test code for helper - change file filename
- add assert functions - refactor original util functions
onlyhyde
changed the title
r3v4s
reviewed
Dec 11, 2024
r3v4s
reviewed
Dec 11, 2024
|
Adding wait-other-pr label ( seems like #432 needs to be merge first ) |
|
r3v4s
approved these changes
Dec 16, 2024
notJoon
approved these changes
Dec 16, 2024
onlyhyde
added a commit
that referenced
this pull request
Dec 18, 2024
* GSW-1839 refactor: integrated helper and test code - integrated helper with nft helper - add test helper code - add test code for helper - change file filename * GSW-1839 refactor: utils - add assert functions - refactor original util functions * Update position/utils_test.gno * test: Update to use the correct test values --------- Co-authored-by: Blake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.