refactor(staker): staker

[notJoon]

Description

• Remove unused internal functions and imports
• Moved external incentive related functions from the staker file to a separate staker_external_incentive file
• Extract condition check as functions
• Change the parameters of the getTokenPairBalanceFromPosition function
  • The pool path is already obtained before this function is called with pn.PositionGetPositionPoolKey(tokenId) method, it is unnecessary to process it internally.

- func getTokenPairBalanceFromPosition(tokenId uint64) (string, string) {
+ func getTokenPairBalanceFromPosition(poolPath string, tokenId uint64) (string, string) {
- 	poolKey := pn.PositionGetPositionPoolKey(tokenId)
        // ...
}

Newly Added Test Files

• manage_pool_tiers
• reward_internal_emission
• reward_manager
• reward_recipient_store
• staker

Test Result

[r3v4s]

• do not inline get -> data check -> if nil panic -> if not nil type assertion for avl data
  • make it as separate function
• for testcase screenshot, run it from gnoswap's repo(with current br branch), not from gno

[notJoon]

* for testcase screenshot, run it from gnoswap's repo(with current br branch), not from gno

I don't think this will be a problem, since I just moved the entire main branch over to the gno side.

[sonarqubecloud]

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
5.8% Duplication on New Code

See analysis details on SonarQube Cloud