Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1845 refactor: gns (halving related) #439

Merged
merged 17 commits into from
Dec 27, 2024
Merged

GSW-1845 refactor: gns (halving related) #439

merged 17 commits into from
Dec 27, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 13, 2024 •
edited
Loading

Description

  1. replace map to []array

turns out key-value (map or avl) really doesn't need for gns.

  1. make unit test as simple as possible (complete test goes into test folder as scenario test)
  2. use const as much as possible rather than hard coded value
  3. add more halving related testcase

image

@r3v4s r3v4s added the wait-other-pr other pr(s) should merge first label Dec 13, 2024
@r3v4s r3v4s force-pushed the refactor/gns-map-to-avl branch 2 times, most recently from a034b96 to 1e39849 Compare December 19, 2024 01:59
@r3v4s r3v4s self-assigned this Dec 19, 2024
@r3v4s r3v4s added token align with grc20 or token related tasks staker and removed wait-other-pr other pr(s) should merge first labels Dec 19, 2024
@r3v4s r3v4s marked this pull request as ready for review December 19, 2024 02:04
notJoon
notJoon requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments. Also, I think it would be better if the declarations of constant and variables were more structed.

_deploy/r/gnoswap/gns/halving.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gns/halving.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gns/halving.gno Outdated Show resolved Hide resolved
@r3v4s r3v4s marked this pull request as draft December 19, 2024 12:51
@r3v4s r3v4s force-pushed the refactor/gns-map-to-avl branch 2 times, most recently from 33f1ce4 to b98a424 Compare December 20, 2024 09:53
@r3v4s r3v4s changed the title GSW-1845 refactor: use avl.Tree in gns GSW-1845 refactor: gns (halving related) Dec 20, 2024
@r3v4s r3v4s force-pushed the refactor/gns-map-to-avl branch from 24ccc1f to 62faf25 Compare December 20, 2024 10:15
@r3v4s r3v4s marked this pull request as ready for review December 20, 2024 10:16
notJoon
notJoon previously approved these changes Dec 22, 2024
View reviewed changes
@onlyhyde onlyhyde force-pushed the refactor/gns-map-to-avl branch from 62faf25 to 75e4f39 Compare December 23, 2024 11:25
@onlyhyde onlyhyde force-pushed the refactor/gns-map-to-avl branch from bd05657 to eb504f2 Compare December 27, 2024 06:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud

@onlyhyde onlyhyde merged commit a055c68 into main Dec 27, 2024
2 checks passed
@onlyhyde onlyhyde deleted the refactor/gns-map-to-avl branch December 27, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde onlyhyde approved these changes

@notJoon notJoon notJoon approved these changes

@mconcat mconcat Awaiting requested review from mconcat

@dongwon8247 dongwon8247 Awaiting requested review from dongwon8247

Assignees

@r3v4s r3v4s

Labels
staker token align with grc20 or token related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @notJoon @onlyhyde