GSW-1839 refactor: use avl.Tree in position #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r3v4s
force-pushed
the
refactor/position-avl-tree
branch
from
c1d66c2 to
2aa6c3a
Compare
notJoon
requested changes
Dec 17, 2024
- keep tokenId type as uint64 ( seqid is not necessary for position contract )
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
Co-authored-by: Lee ByeongJun <[email protected]>
onlyhyde
force-pushed
the
refactor/position-avl-tree
branch
from
529fd2f to
ab7c9c5
Compare
|
onlyhyde
approved these changes
Dec 20, 2024
notJoon
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor
avl.Treeinstead of mapunit64type for tokenId (no need to use seqid type for it)