Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/pool total #442

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Refactor/pool total #442

merged 10 commits into from
Dec 18, 2024

Conversation

onlyhyde
Copy link
Member

@onlyhyde onlyhyde commented Dec 16, 2024 •
edited
Loading

  • refactoring pool's mint function

screenshot

스크린샷 2024-12-17 오후 3 20 49

@onlyhyde onlyhyde marked this pull request as draft December 16, 2024 14:24
@onlyhyde onlyhyde self-assigned this Dec 16, 2024
@onlyhyde onlyhyde added refactoring pool Pool contract related tasks labels Dec 16, 2024
@onlyhyde onlyhyde force-pushed the refactor/pool-total branch from 29efa92 to f12d970 Compare December 17, 2024 10:05
@onlyhyde onlyhyde marked this pull request as ready for review December 18, 2024 04:23
r3v4s
r3v4s reviewed Dec 18, 2024
View reviewed changes
pool/pool_manager.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Dec 18, 2024
View reviewed changes
pool/pool_manager.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Dec 18, 2024
View reviewed changes
pool/pool_manager.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Dec 18, 2024
View reviewed changes
pool/position_test.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, very few changes needed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

r3v4s
r3v4s approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@onlyhyde onlyhyde merged commit c2a133b into main Dec 18, 2024
1 of 2 checks passed
@onlyhyde onlyhyde deleted the refactor/pool-total branch December 18, 2024 06:47
onlyhyde added a commit that referenced this pull request Dec 18, 2024
@onlyhyde
Refactor/pool total (#442)
075aae0 
* refactor: pool mint
* refactor: name change transferFromAndVerify to safeTransferFrom
* refactor: support checkTick when position modify
* refactor: tick and position update
* refactor: pool mint
* refactor: collect and burn
* refactor: collectProtocol
* refactor: setFeeProtocol
* refactor: createPool
* refactor: Modify code based on code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r3v4s r3v4s r3v4s approved these changes

@notJoon notJoon notJoon approved these changes

@dongwon8247 dongwon8247 Awaiting requested review from dongwon8247

Assignees

@onlyhyde onlyhyde

Labels
pool Pool contract related tasks refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onlyhyde @notJoon @r3v4s