Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1968 refactor: commonly used functions #444

Merged
merged 7 commits into from
Dec 20, 2024
Merged

GSW-1968 refactor: commonly used functions #444

merged 7 commits into from
Dec 20, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 17, 2024 •
edited
Loading

Description

  1. implements commonly used functions
  • it must be a public function

@notJoon notJoon mentioned this pull request Dec 18, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@r3v4s r3v4s self-assigned this Dec 18, 2024
@r3v4s r3v4s requested review from notJoon and onlyhyde December 18, 2024 04:50
@r3v4s r3v4s changed the title feat common funcs (WIP) GSW-1968 refactor: commonly used functions Dec 18, 2024
@r3v4s r3v4s marked this pull request as ready for review December 18, 2024 04:51
@r3v4s r3v4s merged commit cf9d52f into main Dec 20, 2024
1 of 2 checks passed
@r3v4s r3v4s deleted the refactor/common-functions branch December 20, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde onlyhyde approved these changes

@notJoon notJoon notJoon approved these changes

Assignees

@r3v4s r3v4s

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @notJoon @onlyhyde