Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(position): Position #445

Closed
wants to merge 73 commits into from
Closed

refactor(position): Position #445

wants to merge 73 commits into from

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Dec 18, 2024

Description

WIP

Changes

Function

Mint

  • Mint
  • handleNativeToken, handleLeftoverNativeToken: Extracted the condition that checks for native tokens into a function (hasNativeToken) and applied it. 373a410

CollectFee

Increase Liquidity

Others

  • addLiquidity: changed to returning error type 5dad2b6

Type

  • MintInput, TokenPair, ProcessedMintInput: Introduced new types for handling states for minting. 039399f

Minor

  • removed position.gno__{function name} prefix from error messsages 7e6952f
  • moved functions and tests from the helper file to the utils file 997e0c7
  • moved GetOrigPkgAddr() function from gno_helper to utils 997e0c7
  • changed to returning error value in the wrap function 188179c

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants