-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(position): Position #445
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlyhyde
force-pushed
the
refactor-position
branch
from
December 18, 2024 06:58
a081d2e
to
3c63a54
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
Changes
Function
Mint
Mint
handleNativeToken
,handleLeftoverNativeToken
: Extracted the condition that checks for native tokens into a function (hasNativeToken
) and applied it. 373a410CollectFee
CollectFee
7fc2ed3Increase Liquidity
increaseLiquidity
: a4d96a7Others
addLiquidity
: changed to returning error type 5dad2b6Type
MintInput
,TokenPair
,ProcessedMintInput
: Introduced new types for handling states for minting. 039399fMinor
position.gno__{function name}
prefix from error messsages 7e6952fhelper
file to theutils
file 997e0c7GetOrigPkgAddr()
function fromgno_helper
toutils
997e0c7wrap
function 188179c