Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1838 fix: pool's scenario test in tests folder #446

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GSW-1838 fix: pool's scenario test in tests folder #446

wants to merge 3 commits into from
+389 −458

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 21, 2024 •
edited
Loading

Description

  1. remove old error template (fileName__funcName())
  2. fix transferFrom check logic
    -- transfer() expected amount to be 0 or negative value.
  3. fix pool's all scenario tests

@r3v4s r3v4s added refactoring pool Pool contract related tasks labels Dec 21, 2024
@r3v4s r3v4s requested review from notJoon and onlyhyde December 21, 2024 07:58
@r3v4s r3v4s self-assigned this Dec 21, 2024
notJoon
notJoon previously approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@r3v4s r3v4s force-pushed the fix/pool-scenario-tests branch from a929370 to e5dbf00 Compare December 21, 2024 14:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@r3v4s r3v4s requested a review from notJoon December 21, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde Awaiting requested review from onlyhyde

@notJoon notJoon Awaiting requested review from notJoon

At least 2 approving reviews are required to merge this pull request.

Assignees

@r3v4s r3v4s

Labels
pool Pool contract related tasks refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v4s @notJoon