Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1844 refactor: query distributed amount for each targets #449

Merged
merged 10 commits into from
Dec 27, 2024
Merged

GSW-1844 refactor: query distributed amount for each targets #449

merged 10 commits into from
Dec 27, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 23, 2024

Description

  1. getter(and setter) for each emission distribution target's distributed and accumualted amount
  2. return distributed amount in MintAndDistributeGns
  3. make unnecessary public setter to private
  4. if amount left due to rounding errors, save it to distribute in next time
  5. replace to map to avl

@r3v4s r3v4s requested review from notJoon and onlyhyde December 23, 2024 06:22
@r3v4s r3v4s changed the title GSW-1844 GSW-1844 refactor: query distributed amount for each targets Dec 23, 2024
notJoon
notJoon previously approved these changes Dec 26, 2024
View reviewed changes
@onlyhyde onlyhyde force-pushed the feat/emission-query-distributed-amount branch from 62d4859 to 9d595a6 Compare December 27, 2024 03:25
notJoon
notJoon previously approved these changes Dec 27, 2024
View reviewed changes
@onlyhyde onlyhyde force-pushed the feat/emission-query-distributed-amount branch from 031b809 to 3486805 Compare December 27, 2024 06:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@r3v4s r3v4s self-assigned this Dec 27, 2024
notJoon
notJoon approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@onlyhyde onlyhyde merged commit cc944ee into main Dec 27, 2024
2 checks passed
@onlyhyde onlyhyde deleted the feat/emission-query-distributed-amount branch December 27, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde onlyhyde approved these changes

@notJoon notJoon notJoon approved these changes

Assignees

@r3v4s r3v4s

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @notJoon @onlyhyde