-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Launchpad Architecture Refactoring #451
Draft
notJoon
wants to merge
19
commits into
main
Choose a base branch
from
refactor-launchpad
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notJoon
changed the title
refactor: launchpad
refactor: Launchpad Architecture Refactoring
Jan 2, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a comprehensive refactoring of the Launchpad contract architecture, focusing on optimizing reward calculations and improving data structure efficiency. The main goals are to reduce computational overhead, enhance gas efficiency, and improve the overall maintainability of the codebase.
Key Changes
Architectural Improvements
ProjectInput
,ProjectTierInfo
,DepositState
)Code Structure
Major Refactored Components
Project Management (
launchpad_init.gno
->launchpad.gno
)validateProjectInput
createTier
Reward Handling (
launchpad_reward.gno
->reward.gno
)Deposit Management (
launchpad_deposit.gno
)DepositState
for better state managementvalidateDepositCollection
)Simplified and More Organized Types
TimeInfo
: Consolidated height and timestamp pairsProjectStats
: Grouped project statistics fieldsRefundInfo
: Consolidated refund-related fieldsProject Structure Improvements
Project
struct for better maintainability:map[uint64]Tier
)tiersRatios
map for cleaner ratio managementTimeInfo
ProjectStats
RefundInfo
Benefits of New Structure
Memory Optimization
Performance Considerations
Future Improvements