Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSW-1668 feat: use grc20reg to support multiple grc20 tokens #452

Merged
merged 7 commits into from
Dec 27, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 26, 2024

Description

  • use grc20reg realm instead previous token_register pattern to support grc20 tokens
  • since grc20reg doesn't provide registered token lists, we need to parse it by calling Render()

@r3v4s r3v4s requested review from onlyhyde and notJoon and removed request for onlyhyde December 26, 2024 12:14
@r3v4s r3v4s self-assigned this Dec 26, 2024
@r3v4s r3v4s added refactoring token align with grc20 or token related tasks labels Dec 26, 2024
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left some comments

_deploy/r/gnoswap/common/grc20reg_helper.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/common/grc20reg_helper.gno Outdated Show resolved Hide resolved
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@onlyhyde onlyhyde force-pushed the refactor/use-grc20reg branch from ad4d977 to b964750 Compare December 27, 2024 06:14
@onlyhyde onlyhyde merged commit e138837 into main Dec 27, 2024
2 checks passed
@onlyhyde onlyhyde deleted the refactor/use-grc20reg branch December 27, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring token align with grc20 or token related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants