Fix fallback fonts' handling and building with -flto=auto (Fixes: #159, Fixes: #144, Fixes: #165)
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility with local users' config.h
|
👌😸 ready for review |
actionless
changed the title
-flto=auto (fixes #159)-flto=auto (Fixes: #159)
actionless
changed the title
-flto=auto (Fixes: #159)-flto=auto (Fixes: #159, Fixes: #144)
|
i was feeling funny, so also fixed another related issue which was happening amongst same-ish lines of code 😺 |
actionless
changed the title
-flto=auto (Fixes: #159, Fixes: #144)-flto=auto (Fixes: #159, Fixes: #144)
|
also it's normally recommended to free() dynamically allocated arrays before the app exit, HOWEVER it's not done for any other cases in st/xst codebase so i guess i shouldn't add that clean-up either |
actionless
commented
Nov 7, 2024
| @@ -22,4 +22,4 @@ jobs: | |||
| - name: smoke test build | |||
| run: xvfb-run ./xst bash -c exit | |||
| - name: smoke test install | |||
| run: xvfb-run xst bash -c exit | |||
| run: sync ; sleep 0.1 ; xvfb-run xst bash -c exit | |||
There was a problem hiding this comment.
(for some reason this step is starting to execute sometimes before the file actually created in the filesystem)
|
@neeasade also i think we'll need to publish a minor release after merging this |
actionless
changed the title
-flto=auto (Fixes: #159, Fixes: #144)-flto=auto (Fixes: #159, Fixes: #144, Fixes: #165)
actionless
force-pushed
the
flto-auto
branch
from
e4adbcf to
5e7f242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(pls squash when merging with msg:
fix fallback fonts' handling)Fixes: #159, Fixes: #144, Fixes: #165