Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic 3.2.0 #451

Merged
merged 2 commits into from
May 15, 2024
Merged

Symbolic 3.2.0 #451

merged 2 commits into from
May 15, 2024

Conversation

cbm755
Copy link
Contributor

@cbm755 cbm755 commented May 14, 2024

New release. Also belatedly adjust the URLs because Symbolic moved into the gnu-octave/ namespace

@mmuetzel
Copy link
Member

Thank you for updating the package.

@mmuetzel mmuetzel merged commit d66e27a into main May 15, 2024
2 checks passed
@mmuetzel
Copy link
Member

I noticed that you added a tarball to the GitHub releases in the past. E.g., https://github.com/gnu-octave/symbolic/releases/download/v3.1.1/symbolic-3.1.1.tar.gz

I didn't find the corresponding release tarball for version 3.2.0. Is that intentional?

@cbm755
Copy link
Contributor Author

cbm755 commented May 15, 2024

Not intentional, fixed. (the official tarball is on sourceforge but can't hurt to mirror)

@cbm755 cbm755 deleted the symbolic-3.2.0 branch May 15, 2024 14:11
@mmuetzel
Copy link
Member

mmuetzel commented May 15, 2024

Thank you for mirroring the tarball also on GitHub.

I noticed that it was missing when I tried to update MXE Octave to package the newer version of the symbolic package (e.g., for Octave for Windows). At some point, the build rules in MXE Octave were change to download the tarball from GitHub. IIRC, that was done because downloading it from SourceForge was sometimes slow or unreliable.
The existing build rules in MXE Octave seem to be working with the new version now, too. 🎉

While testing the new version, I noticed that it prints something like Symbolic pkg v3.1.1+: on first use. Also the folder that Octave selects to install the package contains symbolic-3.1.1+. I haven't checked. But maybe that is coming from the DESCRIPTION file. That file contains a line Version: 3.1.1+. (Also, the Date value might be wrong.)
Should that be updated to 3.2.0 (or 3.2.1 in case that requires a new release)?

Edit: The file at the tagged commit seems to be correct. But the tarball (on SourceForge and on GitHub) seems to contain an older version of the DESCRIPTION file.

@cbm755
Copy link
Contributor Author

cbm755 commented May 15, 2024

Oops, yeah that'll need a new release, will do 3.2.1 later today, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package release New package release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants