Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Test Expectations #1311

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Modified Test Expectations #1311

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c64bdae
"Update assert statement in intersect.m to check size of C instead of…
Sonu0305 Nov 10, 2024
8b61145
added name to copyright header
Sonu0305 Nov 10, 2024
2b0525b
assertion line modified
Sonu0305 Nov 11, 2024
56aedec
added email to copyright header
Sonu0305 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/@sym/intersect.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
%! % empty input
%! A = sym([1 2]);
%! C = intersect(A, []);
%! assert (isequal (C, sym([])))
%! assert (isequal (size(C), [1, 0]))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would assert (isempty (C)) work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(advantage is test would pass on both new and old sympy)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would assert (isempty (C)) work?

Yes, this too is likely to work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please make that change too then and we'll get this merged.


%!test
%! % scalar
Expand Down
Loading