Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sinint #425

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Sinint #425

wants to merge 5 commits into from

Conversation

cbm755
Copy link
Collaborator

@cbm755 cbm755 commented Apr 25, 2016

This isn't very good (not accurate enough), its just an import from specfun package with (failing) tests added.

cbm755 added 5 commits April 23, 2016 23:09
Original author seems to be Sylvain Pelissier, already on our
contributors list.  Others also made changes---as always, please
let us know if you feel you should be on the contributors list
for Symbolic!
@latot
Copy link
Contributor

latot commented Sep 23, 2016

maybe this can be closed? actually exist a Sinint in @sym/sinint or this pr have other objetive?

@cbm755
Copy link
Collaborator Author

cbm755 commented Sep 27, 2016

Other objective. This was a @double/sinint implementation in pure Octave (as we are merging stuff from the old specfun package). But its poor code. Instead I did a @double/sinint that calls sympy (actually mpmath) which is kinda slow.

Longer-term, someone might want a "proper" Octave-native sinint. I'll leave this open for a bit, as I'm not sure this story is done yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants