Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notice #121

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix notice #121

wants to merge 3 commits into from

Conversation

gnugat
Copy link
Owner

@gnugat gnugat commented Apr 5, 2015

Fixes issue #120

@gnugat gnugat added the bug label Apr 5, 2015
@gnugat gnugat self-assigned this Apr 5, 2015
@pyrech
Copy link
Contributor

pyrech commented Apr 5, 2015

👍
Will you squash your commits before merging? I don't think the first commit and the revert should appear in the history 😉

@gnugat
Copy link
Owner Author

gnugat commented Apr 5, 2015

Thanks for the review @pyrech, I've squashed the commits. We'll wait for more information on the issue before merging (I'd like to add a test for it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants