Agsdoc html style update #440
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfm I notice some indenting issues. Check generated header or paragraphs. Here head has too much indentation. I had a look at Here instead P is closed too much, but it may be a different issue, coming from the source comment itself? |
|
Part if the problem is outputting whitespace from around the elements if the gsdic onto the html. I added a fix for the top level elements.
In general the tool doesn't try very hard to indent the html though.
…
On 22 Aug 2024 at 13:41, Riccardo ***@***.***> wrote:
@rfm I notice some indenting issues. Check generated header or paragraphs.
Here head has too much indentation.
<html lang="en"> <head> <meta charset="utf-8"> <title>GNUstep Base</title> <style type="text/css"> hr.method-separator { width:25%; margin-left:0; } </style> </head>
I had a look at - (void) outputNode: (GSXMLNode*)node to: (NSMutableString*)buf whch appears to be the first direct call from outputDocument: L434 and it looks nested fine to me. Do you spot the error?
Here instead P is closed too much, but it may be a different issue, coming from the source comment itself?
<p> The GNUstep Base library is a free software package implementing the API of the OpenStep Foundation Kit (tm), including later additions. This documentation package describes the core of the Base library, for documentation on additional classes, see the BaseAdditions documentation package. </p>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Proposed fix: 21f2cd0 @rfm what do you think? |
…by copying an existing resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR to work together and comment, @rfm