-
Notifications
You must be signed in to change notification settings - Fork 109
Add skeletal implementation of NSGestureRecognizer #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements skeletal implementations of several NSGestureRecognizer subclasses and enhances NSEvent to support magnification gestures. The implementation provides a comprehensive gesture recognition framework with concrete recognizers for common gesture types.
- Implements NSGestureRecognizer base class with state management, target-action patterns, and delegate support
- Adds concrete gesture recognizers for click, pan, press, rotation, and magnification gestures with complete event handling
- Extends NSEvent to support magnification properties for enhanced gesture recognition capabilities
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
NSGestureRecognizer.m | Core gesture recognizer base class implementation with state management and event handling |
NSClickGestureRecognizer.m | Click gesture recognizer with button mask and multi-click support |
NSPanGestureRecognizer.m | Pan gesture recognizer with translation/velocity tracking and multi-button support |
NSPressGestureRecognizer.m | Press-and-hold gesture recognizer with timer-based duration validation |
NSRotationGestureRecognizer.m | Rotation gesture recognizer supporting both mouse and scroll wheel input |
NSMagnificationGestureRecognizer.m | Magnification gesture recognizer for zoom operations |
NSEvent.m | Enhanced mouse event creation and serialization to support magnification data |
Headers/AppKit/*.h | Updated header files with comprehensive documentation and API definitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
…gui into NSGestureRecognizer_branch
Implement Gesture recognition logic