Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jemalloc to 5.2.1 #130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

sfackler
Copy link
Collaborator

No description provided.

@sfackler sfackler requested a review from gnzlbg July 30, 2019 22:23
@gnzlbg
Copy link
Owner

gnzlbg commented Jul 31, 2019

@sfackler this LGTM, but CI fails to build everywhere. I don't know if this is due to this PR, or if it also happens on master. How urgent is this for you ?

@sfackler
Copy link
Collaborator Author

Oh, looks like their makefile changed. I'll look into it.

@sfackler
Copy link
Collaborator Author

It looks like one of the junit tests is failing?

test_prof_log_many_traces:../jemalloc/test/unit/prof_log.c:133: Failed assertion: (jet_prof_log_bt_count()) == (8) --> 10 != 8: Wrong number of backtraces given sample workload
test_prof_log_many_traces (non-reentrant): fail

@sfackler sfackler changed the title Upgrade jemalloc to 5.2.0 Upgrade jemalloc to 5.2.1 Aug 8, 2019
@sfackler
Copy link
Collaborator Author

Ping - this is now failing for the same reason master is.

@sfackler
Copy link
Collaborator Author

Ping

@gnzlbg
Copy link
Owner

gnzlbg commented Oct 13, 2019

Upgrading jemalloc causes so many problems every time that I believe master should be green before performing the upgrade. I don't know when I'll have the time to work on that, but I can mentor anyone who wants to work on it.

@valtog
Copy link

valtog commented Oct 30, 2019

@gnzlbg @sfackler The problem looks to be in ctest. Do you mind fixing ctest at =0.2.14 (last good version) for the time being?

Recent ctest emits function types where function pointers should be, so the compiler complains.

@Noah-Kennedy
Copy link

@sfackler I realize that it has been two years, but what is the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants