Fixes for Legend label centering and wrapping #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes and improves legend label positioning with the following changes: * The legend was previously incorrectly calculating the center position, this is now fixed for cases where wrapping is not necessary (and resulted in a lot of test assertion updates) * When horizontal legends wrap the starting position is now based off the original start positon instead of just `0`. * In addition `Align` `center` is now supported. This is similar to a `left` align, but when wrapping the next line will be centered under the above line (including any set Left adjustement).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and improves legend label positioning with the following changes:
0.Aligncenteris now supported. This is similar to aleftalign, but when wrapping the next line will be centered under the above line (including any set Left adjustment).This PR fixes #29
