[v0.5] Remove Deprecated and Replaced API #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jentfoo
force-pushed
the
jent/v0.5-remove_deprecated
branch
2 times, most recently
from
7bac25d to
ea7c49a
Compare
This change matches other configuration where we accept bool pointers. Allowing the default (nil) to be able to be enabled or disabled depending on other configuration (specifically if the series is stacked). But also allowing a user to override this option and force a behavior.
jentfoo
force-pushed
the
jent/v0.5-remove_deprecated
branch
from
ea7c49a to
e9bfb8e
Compare
|
Replaced with a single v0.5 PR: #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the API replaced and removed for the v0.5 release. Additional v0.5 PR's:
Before merging we will describe all API changes on our version migration guide here: https://github.com/go-analyze/charts/wiki/Version-Migration-Guide