Add generic image #20
Conversation
This image can be used as reference "generic" image for any architectures supported by debian. Boot on PC (x86 or x86_64) is supported thanks to grub, extra tweaking might be needed to boot other architectures on virtual machines. For the record, this is inspired from recipes I wrote for emilia pinball. Change-Id: I709a456f196df337c3f368f03416defe6aadcb0b Forwarded: go-debos#20 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
af2abc0
to
efbc822
Compare
|
Review welcome cc: @sjoerdsimons |
generic/debimage-generic.yaml
Outdated
| {{if eq $architecture "i386" "amd64"}} | ||
| grub-pc, | ||
| {{end}} | ||
| {{if eq $suite "buster" "stable"}} |
There was a problem hiding this comment.
Why are you checking the suite? On other suites the kernel name is different?
generic/debimage-generic.yaml
Outdated
| linux-image-{{$architecture}} | ||
| {{end}} | ||
| {{else}} | ||
| linux-image-generic |
There was a problem hiding this comment.
It's a virtual package introduced around 5.10.0 see
apt-cache show linux-image-amd64 | grep generic
Provides: linux-image-generic, linux-latest-modules-5.10.0-3-amd64, virtualbox-guest-modules, wireguard-modules (= 1.0.0)
Precisely with this change:
https://salsa.debian.org/kernel-team/linux/-/commit/59aeb16cb8bf39ed4e9693a9badb3ce6c38b43e3
generic/debimage-generic.yaml
Outdated
| linux-image-686 | ||
| {{else}} | ||
| linux-image-{{$architecture}} | ||
| {{end}} |
There was a problem hiding this comment.
I would move that to the top and make a kernel variable like in https://github.com/go-debos/debos-recipes/blob/master/rpi64/debimage-rpi64.yaml#L52
There was a problem hiding this comment.
You could use
{{- $kernel := or .kernel (printf "linux-image-%s" $architecture) -}}
{{if eq $architecture "i386"}}
{{ $kernel = or .kernel "linux-image-686" }}
{{end}}
| - action: apt | ||
| packages: [ | ||
| {{if eq $architecture "i386" "amd64"}} | ||
| grub-pc, |
There was a problem hiding this comment.
maybe this one will be enough
#21 (review)
generic/debimage-generic.yaml
Outdated
| - action: run | ||
| chroot: true | ||
| description: Set hostname | ||
| command: echo "{{$architecture}}" > /etc/hostname |
There was a problem hiding this comment.
I think that it's a very bad idea to set hostname to arch.
There was a problem hiding this comment.
because this would break genericity ? I could use "debian" or just suite name
|
I opened a PR for a generic EFI image: #21 |
This image can be used as reference "generic" image for any architectures supported by debian. Boot on PC (x86 or x86_64) is supported thanks to grub, extra tweaking might be needed to boot other architectures on virtual machines. For the record, this is inspired from recipes I wrote for emilia pinball. Change-Id: I709a456f196df337c3f368f03416defe6aadcb0b Forwarded: go-debos#20 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
efbc822
to
0409307
Compare
This image can be used as reference "generic" image
for any architectures supported by debian.
Boot on PC (x86 or x86_64) is supported thanks to grub,
extra tweaking might be needed to boot other architectures
on virtual machines.
For the record, this is inspired from recipes
I wrote for emilia pinball.
Change-Id: I709a456f196df337c3f368f03416defe6aadcb0b
Signed-off-by: Philippe Coval [email protected]