actions: Support for local packages installation #165

fdanis-oss · 2019-05-29T16:04:02Z

This add a new 'source' option to 'apt' action, allowing to install local
packages from the 'source' directory in addition to the repository.

Fix #157

Signed-off-by: Frédéric Danis [email protected]

andhe · 2019-06-26T11:29:38Z

bikeshedding: I think "source" may be a bit unfortunate name/keyword for this as it's not obvious what it would mean without a description. eg. it could (incorrectly) be interpretted as source code, source packages, etc. Is there any other more obvious keyword that fits better perhaps? Just thinks it's useful to consider the question now, because once it's in changing it would break recipies which would be bad....

fdanis-oss · 2019-06-28T10:06:00Z

yes, you're right, what about "local-packages-dir"?

obbardc · 2020-04-28T10:34:13Z

actions/apt_action.go

@@ -49,6 +56,49 @@ func (apt *AptAction) Run(context *debos.DebosContext) error {
 	aptOptions = append(aptOptions, "install")
 	aptOptions = append(aptOptions, apt.Packages...)

+	if apt.LocalPackagesDir != "" {
+		localpackagesdir := path.Join(context.RecipeDir, apt.LocalPackagesDir)
+		destination, err := debos.RestrictedPath(context.Rootdir, "/usr/local/debs")


is /usr/local/debs the best place for this ? would a temp directory be better?
i think it is worth allowing the user to optionally override this path from the recipe; for instance the rootfs may be too small.

apt command can only access packages from network or rootfs
the idea is to hide this from user, so I don't think allowing user to set the temporary destination directory is useful

fdanis-oss · 2020-04-28T12:36:00Z

actions/apt_action.go

+		if err != nil {
+			return err
+		}
+		defer os.RemoveAll(destination)


Defer statement runs at the end of the function.
So, the destination directory is only available during this apt action, and subsequent apt actions will not have access to it.

obbardc · 2020-04-28T10:36:51Z

actions/apt_action.go

+
+		// apt-ftparchive tries to read /etc/apt/apt.conf.d, add this path temporarily to prevent warnings
+		os.MkdirAll("/etc/apt/apt.conf.d", 0755)
+		defer os.RemoveAll("/etc/apt/apt.conf.d/")


if this is only a warning i wonder if this should be a separate patch since debootstrap action also moans about this
also, this is in the middle of a chdir, for clarity move it above

I do not see this warning with debootstrap action

As it is related to following apt-ftparchive commands I think doing this here is right place

fdanis-oss · 2020-04-28T12:50:36Z

docker/Dockerfile

@@ -54,6 +54,7 @@ LABEL org.label-schema.docker.cmd 'docker run \
 RUN apt-get update && \
    apt-get install -y --no-install-recommends \
        apt-transport-https \
+        apt-utils \


yes, you're right but this is not managed in this project

obbardc · 2020-04-28T10:47:13Z

actions/apt_action.go

+
+		os.Chdir(currentDir)
+
+		locallist, err := debos.RestrictedPath(context.Rootdir, "/etc/apt/sources.list.d/local.list")


local.list is quite generic

fdanis-oss · 2020-04-28T12:43:16Z

actions/apt_action.go

+			return err
+		}
+		defer os.RemoveAll(locallist)
+		cmd := fmt.Sprintf("echo 'deb [trusted=yes] file:///usr/local/debs/ ./' > %s", locallist)


Defer statement runs at the end of the function.

obbardc · 2020-04-28T10:48:45Z

actions/apt_action.go

+		}
+		defer os.RemoveAll(locallist)
+		cmd := fmt.Sprintf("echo 'deb [trusted=yes] file:///usr/local/debs/ ./' > %s", locallist)
+		err = debos.Command{}.Run("apt", "sh", "-c", cmd)


can this be done as a direct go file write rather than a command?

obbardc · 2020-04-28T10:49:51Z

actions/apt_action.go

@@ -20,10 +21,15 @@ Optional properties:
 - recommends -- boolean indicating if suggested packages will be installed

 - unauthenticated -- boolean indicating if unauthenticated packages can be installed
+- local-packages-dir -- directory containing local packages to be installed


it's not entirely clear without thinking about it where this directory lives - could make it clear that it is under $RECIPEDIR

This add a new 'local-packages-dir' option to 'apt' action, allowing to install local packages from the 'local-packages-dir' directory in addition to the repository. Fix go-debos#157 Signed-off-by: Frédéric Danis <[email protected]>

actions/apt_action.go

+		if err != nil {
+			return err
+		}
+		defer os.RemoveAll(destination)


sjoerdsimons · 2020-05-28T14:35:50Z

What feels incredibly awkward with this action for me is the amount of hakcs it has to do to the root filesystem we're building to "add" the local packages directory;

And then you have to specify the pakcage to install in your normal apt run; however i don't think you generate a policy file to ensure the local file:// archive gets priority so if the os you build against has a newer version there is a chance it install the non-local package..

Would probably be better to simplify this and rather then extending the apt actions have a new action which only install a list of named files (with glob?) using apt install <files> which iirc installs dependencies from other apt sources automatically

that should also support the typical origin keyword one could easily install packages downloaded externally

fdanis-oss · 2020-05-29T08:39:36Z

afaik apt install <files> will only install dependencies from other apt sources, but not from the local directory, and force user to list all packages and their dependencies in the command

The apt-file action allows local .deb packages to be installed using the `apt` command, much like the apt action but for local packages rather than those from apt repositories. Resolves: go-debos#157 Closes: go-debos#165 Signed-off-by: Christopher Obbard <[email protected]>

…debian packages The apt-file action allows local .deb packages to be installed using the `apt` command, much like the apt action but for local packages rather than those from apt repositories. Resolves: go-debos#157 Closes: go-debos#165 Signed-off-by: Christopher Obbard <[email protected]>

The apt-file action allows local .deb packages to be installed using the `apt` command, much like the apt action but for local packages rather than those from apt repositories. Resolves: go-debos#157 Closes: go-debos#165 Signed-off-by: Christopher Obbard <[email protected]>

The install-dpkg action allows local .deb packages to be installed using the apt command, much like the apt action but for local packages rather than for packages retrieved from remote apt repositories. Resolves: go-debos#157 Closes: go-debos#165 Signed-off-by: Christopher Obbard <[email protected]>

obbardc · 2023-07-27T11:08:29Z

Continuing the alternative implementation under #220 so closing this one.

The install-dpkg action allows local .deb packages to be installed using the apt command, much like the apt action but for local packages rather than for packages retrieved from remote apt repositories. Resolves: go-debos#157 Closes: go-debos#165 Signed-off-by: Christopher Obbard <[email protected]>

fdanis-oss force-pushed the local_package branch from 0f8fb38 to 278c836 Compare June 19, 2019 12:50

fdanis-oss force-pushed the local_package branch from 278c836 to cc795a7 Compare August 31, 2019 09:54

obbardc requested changes Apr 28, 2020

View reviewed changes

obbardc added the high-priority label Apr 28, 2020

actions: Support for local packages installation

cd4da4a

This add a new 'local-packages-dir' option to 'apt' action, allowing to install local packages from the 'local-packages-dir' directory in addition to the repository. Fix go-debos#157 Signed-off-by: Frédéric Danis <[email protected]>

fdanis-oss force-pushed the local_package branch from cc795a7 to cd4da4a Compare April 28, 2020 16:43

obbardc requested changes Apr 28, 2020

View reviewed changes

actions/apt_action.go

if err != nil {

return err

}

defer os.RemoveAll(destination)

This comment was marked as resolved.

Sign in to view

obbardc mentioned this pull request Jun 22, 2020

actions: install-deb: Implement action to install local Debian packages #220

Open

obbardc closed this Jul 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

actions: Support for local packages installation #165

actions: Support for local packages installation #165

fdanis-oss commented May 29, 2019

andhe commented Jun 26, 2019

fdanis-oss commented Jun 28, 2019

obbardc Apr 28, 2020

fdanis-oss Apr 28, 2020

This comment was marked as resolved.

fdanis-oss Apr 28, 2020

This comment was marked as resolved.

obbardc Apr 28, 2020

fdanis-oss Apr 28, 2020

This comment was marked as resolved.

fdanis-oss Apr 28, 2020

obbardc Apr 28, 2020

This comment was marked as resolved.

fdanis-oss Apr 28, 2020

obbardc Apr 28, 2020

obbardc Apr 28, 2020

This comment was marked as resolved.

sjoerdsimons commented May 28, 2020

fdanis-oss commented May 29, 2020

obbardc commented Jul 27, 2023


		os.Chdir(currentDir)

		locallist, err := debos.RestrictedPath(context.Rootdir, "/etc/apt/sources.list.d/local.list")

actions: Support for local packages installation #165

actions: Support for local packages installation #165

Conversation

fdanis-oss commented May 29, 2019

andhe commented Jun 26, 2019

fdanis-oss commented Jun 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

sjoerdsimons commented May 28, 2020

fdanis-oss commented May 29, 2020

obbardc commented Jul 27, 2023