actions/image-partition: truncate filesystem label to maximum supported length #271
Conversation
There was a problem hiding this comment.
looking at it properly; we may as well squash these two comments
also add rationale to adding seperate fslabel property in commit message. Something like "Added optional fslabel property to partition to allow truncation of filesystem label and allow user to modify filesystem label without modifying the name."
vigneshraman
force-pushed
the
vigneshraman/debos/issues/251-v1
branch
2 times, most recently
from
24c08d8
to
81b7045
Compare
…ed length Added optional fslabel property to partition to allow truncation of filesystem label and allow user to modify filesystem label without modifying the name. Filesystem label defaults to the name property of the partition. The filesystem label can be up to 11 characters long for vfat, 16 characters long for ext2/3/4, 255 characters long for btrfs, 512 characters long for hfs/hfsplus and 12 characters long for xfs. Any longer labels will be automatically truncated. Fixes: go-debos#251 Suggested-by: Christopher Obbard <[email protected]> Signed-off-by: Vignesh Raman <[email protected]>
vigneshraman
force-pushed
the
vigneshraman/debos/issues/251-v1
branch
from
81b7045
to
aed889e
Compare
vigneshraman
changed the title
| @@ -72,6 +73,12 @@ Optional properties: | |||
| - partlabel -- label for the partition in the GPT partition table. Defaults | |||
| to the `name` property of the partition. May only be used for GPT partitions. | |||
|
|
|||
| - fslabel -- (optional) Sets the volume name (label) of the filesystem. Defaults | |||
There was a problem hiding this comment.
| - fslabel -- (optional) Sets the volume name (label) of the filesystem. Defaults | |
| - fslabel -- label for the filesystem. Defaults |
|
|
||
| switch p.FS { | ||
| case "vfat": | ||
| maxLength = 11 |
There was a problem hiding this comment.
also warn if someone tries to set an fslabel for an unsupported fs (but ignore none type) ? :-)
| if maxLength > 0 && len(p.FSLabel) > maxLength { | ||
| truncated := p.FSLabel[0:maxLength] | ||
| log.Printf("Warning: fs label for %s '%s' is too long; truncated to '%s'", p.Name, p.FSLabel, truncated) | ||
| p.FSLabel = truncated |
There was a problem hiding this comment.
Why truncate rather then erroring out?
|
fwiw this should really just check the name length in verify to error out early if the name is too long; the seperate fslabel doesn't really have a point, if you want to differentiate the partitation label and filesystem labet there is already partlabel for that.. And there really is no point in setting the name to different values other then using it in one of the labels |
Added optional fslabel property to partition to allow truncation of filesystem
label and allow user to modify filesystem label without modifying the name.
Filesystem label defaults to the name property of the partition.
The filesystem label can be up to 11 characters long for vfat, 16 characters
long for ext2/3/4, 255 characters long for btrfs, 512 characters long for
hfs/hfsplus and 12 characters long for xfs. Any longer labels will be
automatically truncated.
Fixes: #251
Suggested-by: Christopher Obbard [email protected]
Signed-off-by: Vignesh Raman [email protected]