Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse the exitcode initialization value #278

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Reverse the exitcode initialization value #278

wants to merge 3 commits into from

Commits on Dec 31, 2023

  1. Reverse the exitcode initialization value 

    Fakemachine is subject to panic and causes Debos to exit success due to
the current logic of the exitcode. For example, the fakemachine function
CopyFileTo() panics if the file is missing.

In the case of a panic, the function never returns. Thus, the exitcode
cannot be set to 1 and Debos exits with 0.

This commit reverses the logic of the exitcode: it is initialized to 1
(i.e. failure), and it is set to 0 (i.e. success) only if Debos has
reached the end of the things it has to do (or for the help message).

Co-authored-by: Gaël PORTAY <[email protected]>
Co-authored-by: Santosh Mahto <[email protected]>

Signed-off-by: Gaël PORTAY <[email protected]>
    @gportay @obbardc
    gportay authored and obbardc committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    225b718 View commit details
    Browse the repository at this point in the history

  2. Add exit code test to validate logic is as expected

    @eds-collabora @obbardc
    eds-collabora authored and obbardc committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    512757d View commit details
    Browse the repository at this point in the history

  3. Capture the exitcode test as a docker compose recipe

    @eds-collabora @obbardc
    eds-collabora authored and obbardc committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    d1b5660 View commit details
    Browse the repository at this point in the history