Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions: overlay: Check source exists during RecipeDir during verification #304

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

actions: overlay: Check source exists during RecipeDir during verification #304

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaf46ca
actions: overlay: Check source exists during RecipeDir during verific…
obbardc Jan 12, 2022
32c0b86
tests: overlay: Add test to overlay missing file
obbardc Jul 27, 2023
add9a02
tests: Rename overlay-non-existent-destination→overlay
obbardc Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/overlay-non-existent-destination/overlay-non-existent-destination.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to do the rename in the same commit where you changed it ? also this seems to only delete not add the new name?

Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
architecture: amd64

actions:
# This overlay action is expected to error out here because the source
# doesn't exist in the recipe directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so now the next part is no longer tested because this one already errored out right or am i missing something?

- action: overlay
description: Overlay non-existent file
source: non-existent-file

# This overlay action is expected to error out here because the destination
# doesn't exist in the filesystem.
- action: overlay
Expand Down