Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: install qemu-user-static from backports #521

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@
# Set HOME to a writable directory in case something wants to cache things
ENV HOME=/tmp

LABEL org.label-schema.name "debos"

Check warning on line 62 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 62 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 62 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 62 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 62 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish to GHCR

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 62 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish to DockerHub

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
LABEL org.label-schema.description "Debian OS builder"

Check warning on line 63 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 63 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 63 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 63 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 63 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish to GHCR

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 63 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish to DockerHub

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
LABEL org.label-schema.vcs-url = "https://github.com/go-debos/debos"

Check warning on line 64 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 64 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 64 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 64 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 64 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish to GHCR

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 64 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish to DockerHub

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
LABEL org.label-schema.docker.cmd 'docker run \

Check warning on line 65 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 65 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 65 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 65 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Build Docker container

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 65 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish to GHCR

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 65 in docker/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish to DockerHub

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
--rm \
--interactive \
--tty \
Expand Down Expand Up @@ -98,7 +98,6 @@
openssh-client \
parted \
pkg-config \
qemu-user-static \
qemu-utils \
rsync \
systemd \
Expand All @@ -115,11 +114,11 @@
arch-install-scripts && \
rm -rf /var/lib/apt/lists/*

# debian's qemu-user-static package no longer registers binfmts
# if running inside a virtualmachine; dockerhub builds are inside a vm
RUN for arch in aarch64 alpha arm armeb cris hexagon hppa m68k microblaze mips mips64 mips64el mipsel mipsn32 mipsn32el ppc ppc64 ppc64le riscv32 riscv64 s390x sh4 sh4eb sparc sparc32plus sparc64 xtensa xtensaeb; do \
update-binfmts --import qemu-$arch; \
done
RUN echo "deb http://deb.debian.org/debian bookworm-backports main" > /etc/apt/sources.list.d/bookworm-backports.list && \
apt-get update && \
apt-get install -y --no-install-recommends -t bookworm-backports \
qemu-user-static && \
rm -rf /var/lib/apt/lists/*

COPY --from=builder $GOPATH/bin/debos /usr/local/bin/debos

Expand Down
2 changes: 1 addition & 1 deletion tests/debian/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ architecture: {{$architecture}}

actions:
- action: debootstrap
suite: bullseye
suite: bookworm
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bullseye bootstrapping test on arm64 fails with newer qemu...

variant: minbase
merged-usr: true

Expand Down