Fix eslint (#33002)

Fix #32982 Related #32869 * eslint-plugin-github 5.1.x doesn't work well with eslint8 * no-undef is still needed
go-gitea · Dec 27, 2024 · ea198f9 · ea198f9
1 parent a7b2707
commit ea198f9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 164 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -674,7 +674,7 @@ module.exports = {
     'no-this-before-super': [2],
     'no-throw-literal': [2],
     'no-undef-init': [2],
-    'no-undef': [0],
+    'no-undef': [2], // it is still needed by eslint & IDE to prompt undefined names in real time
     'no-undefined': [0],
     'no-underscore-dangle': [0],
     'no-unexpected-multiline': [2],

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -86,7 +86,7 @@
     "eslint": "8.57.0",
     "eslint-import-resolver-typescript": "3.7.0",
     "eslint-plugin-array-func": "4.0.0",
-    "eslint-plugin-github": "5.1.4",
+    "eslint-plugin-github": "5.0.2",
     "eslint-plugin-import-x": "4.6.1",
     "eslint-plugin-no-jquery": "3.1.0",
     "eslint-plugin-no-use-extend-native": "0.5.0",